Upgrade to Typescript 5.x and Svelte 4.x #97
Conversation
patricknelson
force-pushed
the
upgrade-typescript5-svelte4
branch
from
1e18d98 to
5d5741e
Compare
| @@ -46,8 +46,10 @@ export default class Processor { | |||
| this.magicContent = new MagicString(content); | |||
| this.styleParser = parser.bind(this); | |||
|
|
|||
| if (!this.ast.css) throw new Error('ast.css is not defined.'); | |||
There was a problem hiding this comment.
Hack: Needed to do this to pass linting since the type of Ast.css changed to be nullable.
| @@ -59,6 +61,8 @@ export default class Processor { | |||
| * @returns The generated module classname | |||
| */ | |||
| public createModuleClassname = (name: string): string => { | |||
| if (!this.ast.css) throw new Error('ast.css is not defined.'); | |||
There was a problem hiding this comment.
Hack: Needed to do this to pass linting since the type of Ast.css changed to be nullable.
| @@ -123,6 +127,7 @@ export default class Processor { | |||
| const child = item.children[0]; | |||
| const name = child.name ?? child.value.replace(/'|"/g, ''); | |||
| const varName = child.type === 'String' ? name.replace(/\./, '-') : name; | |||
| if (!this.ast.css) throw new Error('ast.css is not defined.'); | |||
There was a problem hiding this comment.
Hack: Needed to do this to pass linting since the type of Ast.css changed to be nullable.
| @@ -38,14 +35,15 @@ let pluginOptions: PluginOptions; | |||
| * @returns the preprocessor markup | |||
| */ | |||
| const markup: MarkupPreprocessor = async ({ content, filename }) => { | |||
| const isIncluded = isFileIncluded(pluginOptions.includePaths, filename); | |||
| const useFilename: string = filename || ''; | |||
There was a problem hiding this comment.
Hack? This filename parameter also changed to potentially undefined.
|
waiting for merge |
|
@patricknelson Thank you for you work. When looking at the PR #100 , I ended up encountering the issues you faced on this current PR. I tackled the changes over there based on what you did here. Here are some noticeable differences:
ps: My apologies for not being able to maintain the plugin for about a year |
|
Awesome! And no worries. I see you’ve been heads down working through the issues and cranking out code for at least the past 12 hours or so. Our team uses this plugin regularly, so we love it and we don’t want you burning out! Thanks for the dedication. 😊 |
Possible fix for #93. Quick hack that upgrades TypeScript v4 -> v5 and Svelte v3 -> v4.
I actually did this in an attempt to debug unrelated issues which ended up being a red herring. However, since I already hashed through all of the linting and TypeScript errors, I figured maybe you could benefit from this! Again, this is an ugly hack (particularly just the errors I throw, which I'll call out below). However, this may save you some time later if/when you have time to address this.
Thankfully, Svelte 4 is almost entirely backward compatible with v3, the main differences here where how they defined their types and how they need to be imported (thus the updates to the
importstatements and.eslintrc.js)